Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request][A11Y][Token] Need a parameter to custom the aria-label of the close button for ui5-token component #2187

Closed
Hubery-Shen opened this issue Sep 8, 2020 · 0 comments · Fixed by #2193
Closed

[Feature Request][A11Y][Token] Need a parameter to custom the aria-label of the close button for ui5-token component #2187

Hubery-Shen opened this issue Sep 8, 2020 · 0 comments · Fixed by #2193
Assignees
@fifoosid
Labels
High Prio SAP SF SF_ACC
Milestone
0.23.2

Comments

@Hubery-Shen
Copy link

Dear colleagues,
I am from SuccessFactors Web Experience Shanghai team.

Feature request

  1. Need a parameter to custom the aria-label of the close button for ui5-token component
    FR Token

Expected API Spec

<ui5-token slot="tokens" text="Argentina" close-label="myCloseLabel"></ui5-token>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fifoosid fifoosid

Labels
High Prio SAP SF SF_ACC
Projects
None yet
Milestone
0.23.2
Development

Successfully merging a pull request may close this issue.

feat(ui5-token): provide closeIcon slot SAP/ui5-webcomponents
4 participants
@ilhan007 @fifoosid @nikolay-kolarov @Hubery-Shen