Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-daterange-picker): fixed getters for first and last date values #2277

Merged
merged 4 commits into from
Oct 1, 2020

Conversation

tsanislavgatev
Copy link
Contributor

fixes: #2221

Copy link
Contributor

@fifoosid fifoosid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but you should fix the lint errors

@ilhan007 ilhan007 dismissed fifoosid’s stale review October 1, 2020 16:04

lint is fixed

@ilhan007 ilhan007 merged commit 00f5ab5 into master Oct 1, 2020
@ilhan007 ilhan007 deleted the daterangepicker-datevalue-getters-fix branch October 1, 2020 16:06
ilhan007 pushed a commit that referenced this pull request Oct 17, 2020
Fix the return values of first and last date  public getters, previously returning wrong values.

Fixes #2221
ilhan007 pushed a commit that referenced this pull request Nov 11, 2020
Fix the return values of first and last date  public getters, previously returning wrong values.

Fixes #2221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui5-daterange-picker] Timezone issue - firstDateValue and lastDateValue attributes are wrong
3 participants