refactor(ui5-notification-action): rename component #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgimkv
approved these changes
Dec 15, 2020
niyap
pushed a commit
to niyap/ui5-webcomponents
that referenced
this pull request
Dec 17, 2020
Based on the feedback that NotificationOverflowAction is not completely matching its purpose and usage, as it can be both displayed within and out of the overflow popover of a notification item. We decided to rename it as follows: - rename `NotificationOverflowAction` -> `NotificationAction` - rename `ui5-notification-overflow-action` to `ui5-notification-action` BREAKING_CHANGE If you previously used `ui5-notification-overflow-action` and had the following import statement: ```js import "@ui5/webcomponents-fiori/dist/NotificationOverflowAction.js"; ``` now you have to use the `ui5-notification-action` tag and import the following module: ```js import "@ui5/webcomponents-fiori/dist/NotificationAction.js"; ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the feedback that NotificationOverflowAction is not completely matching its purpose and usage, as it can be both displayed within and out of the overflow popover of a notification item. We decided to rename it as follows:
NotificationOverflowAction->NotificationActionui5-notification-overflow-actiontoui5-notification-actionBREAKING_CHANGE If you previously used
ui5-notification-overflow-actionand had the following import statement:now you have to use the
ui5-notification-actiontag and import the following module: