fix(ui5-popup): correct focus when there is no focusable content #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is no focusable content, the focus should be on the root of the component. Fixes #2556
|
|
dimovpetar
requested review from
a team,
vladitasev,
MapTo0,
ilhan007 and
fifoosid
TeodorTaushanov
previously approved these changes
Dec 18, 2020
vladitasev
previously approved these changes
Jan 7, 2021
packages/main/src/Popup.hbs
Outdated
| @@ -6,6 +6,8 @@ | |||
| aria-label="{{_ariaLabel}}" | |||
| aria-labelledby="{{_ariaLabelledBy}}" | |||
| dir="{{dir}}" | |||
| tabindex="-1" | |||
| @keydown={{_onRootFocusOut}} | |||
There was a problem hiding this comment.
Please call this method _onkeydown. For event handlers it is preferable to call the function based on what event is handled, instead of on what the function does. Later, if you need to implement some other kind of KH, it would have to be in the same method, as it is the one bound to the event, and then the name _onRootFocusOut would no longer be entirely correct and then you would have to rename it to _onkeydown or something similar, so better to do it now.
dimovpetar
dismissed stale reviews from vladitasev and TeodorTaushanov
via
a5db06b
vladitasev
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is no focusable content, the focus should be on the root of the component.
Fixes #2556
Thank you for your contribution! 👏
To get it merged faster, kindly review the checklist below:
Pull Request Checklist