-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-table): add growing on scroll #2593
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
reviewed
Dec 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the API (having an enum instead of 2 booleans)!
We could probably discuss the names and we can merge
MapTo0
approved these changes
Feb 4, 2021
ilhan007
added a commit
that referenced
this pull request
Feb 8, 2021
Adds growing capability to the Table upon user scroll (previously possible through "More" button - see the PR #2589). With this feature, the "load-more" event will be fired when the user scrolls to the table's end. FIXES: #2570 BREAKING_CHANGES: "has-more" removed, use "growing" instead; "load-more-text" has been renamed to more-text; "load-more-subtext" has been renamed to "more-subtext"
NHristov-sap
pushed a commit
to NHristov-sap/ui5-webcomponents
that referenced
this pull request
Feb 9, 2021
Adds growing capability to the Table upon user scroll (previously possible through "More" button - see the PR SAP#2589). With this feature, the "load-more" event will be fired when the user scrolls to the table's end. FIXES: SAP#2570 BREAKING_CHANGES: "has-more" removed, use "growing" instead; "load-more-text" has been renamed to more-text; "load-more-subtext" has been renamed to "more-subtext"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Adds "loadMore" capability to the Table upon user scroll (previously possible trough "More" button - see the PR #2589). With this feature, the "load-more" event will be fired when the user scrolls to the table's end.
FIXES: #2570
BREAKING_CHANGES:
API Changes
-- "None" - growing is off (default)
-- "Scroll" - Table's
load-more
is fired upon user scrolls to the table's end-- "Button" - Table's
load-more
is fired upon pressing a "More" buttonUsage
Example
Busy Indicator placement