fix(ui5-combobox, ui5-multicombobox): center ValueState text #2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValueState text is now vertically centered in the ResponsivePopover of the suggestions. Issue: SAP#2274
ilhan007
requested changes
Jan 26, 2021
There was a problem hiding this comment.
Because the ResponsivePopover.css styles take effect in input with suggestions, combobox, multi combobox, multi input, select and all date-time components, I think the value state text alignment of the text should be checked for them as well.
(1) Check if this is a bug only in the ComboBox
and
(2) make sure the fix won't break the rest of the components.
ndeshev
changed the title
ndeshev
changed the title
…e resp.popover header
|
The issue was also present in MultiComboBox, I added a fix for it and reverted back the previous value of the responsive popover's header CSS height param. |
ilhan007
reviewed
Jan 27, 2021
ilhan007
requested changes
Jan 27, 2021
ilhan007
approved these changes
Jan 27, 2021
alexandar-mitsev
pushed a commit
to alexandar-mitsev/ui5-webcomponents
that referenced
this pull request
Feb 1, 2021
ValueState text is now vertically centered in the Popover's header. Fixes: SAP#2274
NHristov-sap
pushed a commit
to NHristov-sap/ui5-webcomponents
that referenced
this pull request
Feb 9, 2021
ValueState text is now vertically centered in the Popover's header. Fixes: SAP#2274
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValueState text is now vertically centered in the Popover's header.
Issue: #2274