fix(ui5-multiinput): hide placeholder when tokens #2789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
requested changes
Feb 5, 2021
packages/main/src/Input.js
Outdated
| @@ -1176,6 +1176,10 @@ class Input extends UI5Element { | |||
| return isPhone(); | |||
| } | |||
|
|
|||
| get _getPlaceholder() { | |||
There was a problem hiding this comment.
get _get is not needed, it is getter by nature, so you can just use get _placeholder
Also add @ protected to point out that derived classes rely on this getter.
ilhan007
approved these changes
Feb 6, 2021
NHristov-sap
pushed a commit
to NHristov-sap/ui5-webcomponents
that referenced
this pull request
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2261