Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui5-segmentedbutton: the method of interaction for segmented button not clear for screen reader users #2934

Closed
BennyHuang opened this issue Mar 10, 2021 · 3 comments
Assignees
Labels

Comments

@BennyHuang
Copy link

Describe the bug
The method of interaction for segmented button not clear for screen reader users

To reproduce
Open JAWS and focus on the segmented button. The the instruction text announced by JAWS is not clear enough.

Expected behavior
The expected texts for screen reader should be same as what we have for sap.m.SegmentedButton
image

Context
UI5 Web Components version: 0.29.6

Affected components (if known)
ui5-segmentedbutton

Organization: (if applicable)
SAP SuccessFactors

Priority: (optional) (Low, Medium, High or Very High)
Medium

@PetyaMarkovaBogdanova
Copy link
Contributor

Dear colleagues from @SAP/ui5-webcomponents-topic-b,
can you please take a look at this issue.
Now only the selected toggle button is being read out.

Best regards,
Petya.

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova removed their assignment Mar 11, 2021
@tsanislavgatev tsanislavgatev added the bug This issue is a bug in the code label Apr 5, 2021
@ghristanov ghristanov self-assigned this Apr 7, 2021
@ilhan007
Copy link
Member

Hello @BennyHuang thanks for reporting.

We discussed the issue internally with the responsible accessibility expert and it turns out the missing readings you described are caused by the DOM structure utilising buttons, as the component is designed to slot toggle buttons.
While, on UI5 control (sap.m.SegmentedButton) side list of options ("li" elements, instead of buttons) has been used.
To fix the issue, we will need to perform bigger refactoring than expected, not just adding or replacing ARIA attributes, but changing the DOM elements, which might result in replacing the ui5-togglebutton with something else and API breaking change.

For that we will create a backlog for refactoring of the SegmentedButton, once created it will be linked here.
Then, we will close the current issue, but you will be able track the progress within the refactoring backlog (another GitHub issue at the end).

Thanks for the understanding.

BR,
ilhan

@ilhan007
Copy link
Member

Hello @BennyHuang

as mentioned in my previous message, fixing the announcements of the SegmentedButton would require significant refactoring. For that, we created a new issue: #3191

I will close the current one, it's is referenced in the new one for traceability.
You can see the details and follow the progress here: #3191

Best,
ilhan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

No branches or pull requests

6 participants