Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-busyindicator): add a11y support #2938

Merged
merged 10 commits into from
Apr 1, 2021
Merged

fix(ui5-busyindicator): add a11y support #2938

merged 10 commits into from
Apr 1, 2021

Conversation

dimovpetar
Copy link
Contributor

@dimovpetar dimovpetar commented Mar 11, 2021 •
edited
Loading

  • Tooltip is now shown on hover
  • Focus is now on the correct div, so screen readers can read it properly

Fixes #2381

Pull Request Checklist

@dimovpetar
wip(ui5-busyindicator): ACC improvements
1dca3ad 
- Tooltip is now shown on hover
- Focus is now on the correct div, so screen readers can read it properly

Fixes #2381
@dimovpetar
set tabindex to the slot
e7f722c
@dimovpetar
include text property in the announcement
04f3655
@dimovpetar
add testss
11c8e48
@dimovpetar dimovpetar changed the title wip(ui5-busyindicator): ACC improvements fix(ui5-busyindicator): ACC improvements Mar 15, 2021
@dimovpetar dimovpetar requested a review from a team March 15, 2021 16:05
@dimovpetar dimovpetar closed this Mar 18, 2021
@dimovpetar dimovpetar reopened this Mar 18, 2021
@ilhan007 ilhan007 added the ACC label Mar 19, 2021
@GerganaKremenska GerganaKremenska self-requested a review March 30, 2021 13:41
ilhan007
ilhan007 requested changes Mar 30, 2021
View reviewed changes
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dimovpetar could you check if the following is caused by this change, as I can't reproduce it in the master. The loading text looks shifted downwards with this change

Screenshot 2021-03-30 at 17 39 28

Previously it was right below the dots
https://sap.github.io/ui5-webcomponents/master/playground/main/pages/BusyIndicator/

@dimovpetar
Copy link
Contributor Author

Hi @dimovpetar could you check if the following is caused by this change, as I can't reproduce it in the master. The loading text looks shifted downwards with this change

Screenshot 2021-03-30 at 17 39 28

Previously it was right below the dots
https://sap.github.io/ui5-webcomponents/master/playground/main/pages/BusyIndicator/

Yes, I have fixed it now. Also added the case in BusyIndicator.html

@ilhan007 ilhan007 changed the title fix(ui5-busyindicator): ACC improvements fix(ui5-busyindicator): add a11y support Apr 1, 2021
@ilhan007 ilhan007 merged commit cfa50d8 into SAP:master Apr 1, 2021
@ilhan007
Copy link
Member

ilhan007 commented Apr 1, 2021

Hello @ SAP/ui5-webcomponents-topic-rd please update the BusyIndicator Accessibility wiki page.

@ilhan007 ilhan007 added the SAP SF label Apr 1, 2021
ilhan007 pushed a commit that referenced this pull request Apr 1, 2021
@dimovpetar @ilhan007
fix(ui5-busyindicator): add a11y support (#2938)
f46e6ee 
Tooltip, Focus is provided, so screen readers can read the component properly

Fixes #2381
ilhan007 pushed a commit that referenced this pull request Apr 1, 2021
@dimovpetar @ilhan007
fix(ui5-busyindicator): add a11y support (#2938)
b50de4a 
Tooltip, Focus is provided, so screen readers can read the component properly

Fixes #2381
@dimovpetar
Copy link
Contributor Author

Hello @ SAP/ui5-webcomponents-topic-rd please update the BusyIndicator Accessibility wiki page.

Wiki is now updated :)

@ilhan007
Copy link
Member

ilhan007 commented Apr 5, 2021

Thanks @dimovpetar !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

@TeodorTaushanov TeodorTaushanov TeodorTaushanov left review comments

@GerganaKremenska GerganaKremenska GerganaKremenska left review comments

@fifoosid fifoosid Awaiting requested review from fifoosid

@MapTo0 MapTo0 Awaiting requested review from MapTo0

@elenastoyanovaa elenastoyanovaa Awaiting requested review from elenastoyanovaa

Assignees
No one assigned
Labels
ACC SAP SF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui5-busyindicator accessibility issues
4 participants
@dimovpetar @ilhan007 @TeodorTaushanov @GerganaKremenska