Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][UI5-List] Error edit icon direction in RTL mode #2962

Closed
sfsf-xweb-sh opened this issue Mar 18, 2021 · 4 comments
Closed

[BUG][UI5-List] Error edit icon direction in RTL mode #2962

sfsf-xweb-sh opened this issue Mar 18, 2021 · 4 comments
Assignees
Labels
bug This issue is a bug in the code SAP SF

Comments

@sfsf-xweb-sh
Copy link

Dear colleagues,
I am from SuccessFactors Web Experience Shanghai team.
My name is Hubery Shen and this account is our team account.

Describe the bug
Error edit icon direction in RTL mode
code: <ui5-li icon="edit">edit</ui5-li>
image

@d3xter666 d3xter666 self-assigned this Mar 18, 2021
@d3xter666
Copy link
Contributor

Hi @sfsf-xweb-sh ,

I was not able to reproduce the issue in the playground by setting the mode to RTL

Could you provide a sample with the issue in JSBin, Plunkr or any other suitable tool.

@ilhan007
Copy link
Member

Hello @sfsf-xweb-sh

by default it gets mirrored, but you can force the direction by:

	<ui5-icon name="edit" dir="ltr" ></ui5-icon>

@ilhan007 ilhan007 reopened this Mar 18, 2021
@ilhan007
Copy link
Member

ilhan007 commented Mar 18, 2021

Sorry, the solution above works for the Icon(ui5-icon) if used standalone, but I realised it is in a ListItem (ui5-li) and
you can't set the dir of the Icon( ui5-icon) trough the ListItem (ui5-li).
We will see about this.

@ilhan007
Copy link
Member

Hello @sfsf-xweb-sh

the issue is fixed long time ago with #2645

but not downported in 0.29.

It will be part of the next 0.29.X patch.

BR,
ilhan

@ilhan007 ilhan007 assigned ilhan007 and unassigned d3xter666 Mar 18, 2021
@ilhan007 ilhan007 added consulting bug This issue is a bug in the code and removed consulting labels Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code SAP SF
Projects
None yet
Development

No branches or pull requests

3 participants