fix(ui5-time-picker): accessibility improved #3162
Merged
+73
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ui5-time-picker and ui5-duration picker inner input elements now have aria properties set according to the screen reader specification. Fixes SAP#3010
|
it looks ok to me, but I will wait for your internal review |
ilhan007
reviewed
Apr 22, 2021
|
Hi @tsanislavgatev could you provide a review at least from code perspective. |
ilhan007
requested changes
Apr 22, 2021
ilhan007
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ui5-time-picker and ui5-duration picker inner input
elements and wheel sliders now have aria properties set
according to the screen reader specification.
Fixes #3010