Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui5-label: ui5-label with required symbol is truncated in Safari #3164

Closed
zhangliangyi opened this issue Apr 19, 2021 · 3 comments · Fixed by #3182
Closed

ui5-label: ui5-label with required symbol is truncated in Safari #3164

zhangliangyi opened this issue Apr 19, 2021 · 3 comments · Fixed by #3182
Assignees
Labels
bug This issue is a bug in the code Medium Prio SAP SF TOPIC RD

Comments

@zhangliangyi
Copy link

zhangliangyi commented Apr 19, 2021

Describe the bug
In Safari, the ui5-label with required symbol is truncated.

To reproduce
Steps to reproduce the behavior:

  1. Go to https://sap.github.io/ui5-webcomponents/playground/components/Label/ via Chrome/Edge, check Required Label section.
  2. Go to https://sap.github.io/ui5-webcomponents/playground/components/Label/ via Safari, check Required Label section.
  3. In Safari, the label text is truncated but not in Chrome/Edge.

Expected behavior
The text should not be truncated in Safari.

Context

  • UI5 Web Components version: 0.31.5
  • OS/Platform: MacOS
  • Browser (if relevant): Safari 14.0.3
  • Other information: N/A

Affected components ui5-label

Organization: SF

Priority: (optional) Medium

Setting priority would indicate the importance of the issue
and would help the process of dispatching and processing.

To set the appropriate priority, you need to consider the impact
and if the issue:

  • Breaks entire application or system - High and Very High
  • Is accessibility one (Screen Reader, Keyboard Handling) - Medium and High
  • Is functional one and makes a single component unusable - Medium and High
  • Is visual, styling one - Low and Medium

Note: the priority would be re-evaluated by the issue processors, according to the project internal criterias

Business impact: (mandatory for "Very High")

@alexandar-mitsev alexandar-mitsev self-assigned this Apr 20, 2021
@alexandar-mitsev alexandar-mitsev added bug This issue is a bug in the code Medium Prio TOPIC RD SAP SF labels Apr 20, 2021
@alexandar-mitsev
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-rd ,

The issue is reproducible on Safari on Mac. When the label is required - the text gets truncated. See attached screenshot.
LabelTruncatedSafari

Regards,
Alexandar Mitsev

@zhangliangyi
Copy link
Author

@fifoosid
Seems the fix is not involved in the latest 0.31.8 release. Please add this in next 0.31.x release.

@ilhan007
Copy link
Member

ilhan007 commented Jun 1, 2021

Hello @zhangliangyi sorry about that, now the fix has been downported and will be released next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio SAP SF TOPIC RD
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants