fix(ui5-combobox): enable setting value programatically #3253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The component's desired functionality works and I have no comments on the code. You could add a test testing the fixed behaviour |
ndeshev
previously approved these changes
May 25, 2021
BREAKING CHANGE: filter value property is removed. FIXES: #2233
ilhan007
requested changes
May 28, 2021
|
should be good now. |
|
When you have a selected item/value, the change event is fired as many times as the "ENTER" key is pressed even without changing the value/item. |
|
If you type a letter to show suggestion, for example "A" then click on it with the mouse, change is not fired, neither on click or if enter is pressed after that. |
ndeshev
approved these changes
Jun 25, 2021
ilhan007
approved these changes
Jun 28, 2021
ilhan007
pushed a commit
that referenced
this pull request
Jul 2, 2021
BREAKING CHANGE: filter value property is removed. FIXES: #2233
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can now set value programatically.
filterValueproperty should not be used anymore.valueproperty represents the "live" value of theui5-combobox.Change and Input events continue to fire as before, so users can track values changes.
BREAKING CHANGE: filter value property is removed.
FIXES: #2233