feat(ui5-segmented-button-item): introduce new component to serve as child of SegmentedButton #3258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-added the SBI in the md file -css files properly named -aria-describedby added from i18n files -indentations fixed -property names in SBI adjusted
|
|
ilhan007
changed the title
|
The build is failing due to lint errors: /home/travis/build/SAP/ui5-webcomponents/packages/main/src/SegmentedButton.js
133:4 error 'buttons' is never reassigned. Use 'const' instead prefer-const
140:20 error Unexpected parentheses around single function argument arrow-parens
✖ 2 problems (2 errors, 0 warnings)
1 error and 0 warnings potentially fixable with the `--fix` option.To check the lint loclly, you can run |
ilhan007
requested changes
May 17, 2021
ghristanov
suggested changes
May 17, 2021
ilhan007
requested changes
May 18, 2021
ilhan007
requested changes
May 18, 2021
The unwanted properties, inherited from the Button, are marked as private.
Closed
ilhan007
changed the title
tsanislavgatev
requested changes
May 31, 2021
ilhan007
requested changes
Jun 3, 2021
|
Looks good from our side. Styles, API, and functionality. |
ilhan007
requested changes
Jun 11, 2021
tsanislavgatev
approved these changes
Jun 14, 2021
ilhan007
approved these changes
Jun 14, 2021
ghristanov
approved these changes
Jun 14, 2021
ilhan007
pushed a commit
that referenced
this pull request
Aug 9, 2021
…child of SegmentedButton (#3258) Introduce new component SegmentedButtonItem (ui5-segmentedbutton-item), meant to be used within the SegmentedButton (ui5-segmented-button) as a child, in order to implement a11y compliant DOM structure and attributes. The SegmentedButtonItem replaces the ToggleButton, previously used in the SegmentedButton. Fixes: #3191 Closes: #3191 BREAKING_CHANGE: `selectedButton` event detail of "selection-change" has been renamed to `selectedItem` BREAKING_CHANGE: SegmentedButton no longer accepts ToggleButton, you have to use the newly created component, called SegmentedButtonItem as follows: <ui5-segmentedbutton> <ui5-segmentedbutton-item pressed>One</ui5-segmentedbutton-item> <ui5-segmentedbutton-item>Two</ui5-segmentedbutton-item> <ui5-segmentedbutton-item>Three</ui5-segmentedbutton-item> </ui5-segmentedbutton>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new component SegmentedButtonItem (ui5-segmentedbutton-item), meant to be used within the SegmentedButton (ui5-segmentedbutton) as a child, in order to implement a11y compliant DOM structure and attributes. The SegmentedButtonItem replaces the ToggleButton, previously used in the SegmentedButton.
Fixes #3191
BREAKING_CHANGE: SegmentedButton no longer accepts ToggleButton, you have to use the newly created component, called SegmentedButtonItem as follows: