Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-checkbox): add indeterminate state #3309

Merged
merged 5 commits into from
May 28, 2021
Merged

feat(ui5-checkbox): add indeterminate state #3309

merged 5 commits into from
May 28, 2021

Conversation

nnaydenow
Copy link
Contributor

@nnaydenow nnaydenow commented May 25, 2021

Added new property attribute which determines whether the component is displayed as partially checked.

Fixes: #3217

@nnaydenow nnaydenow requested review from ilhan007 and fifoosid May 25, 2021 11:29
@ilhan007 ilhan007 changed the title feat(ui5-checkbox): add indeterminate attrbiute feat(ui5-checkbox): add indeterminate state May 26, 2021
@ilhan007
Copy link
Member

I tried it out - just minor JS doc improvements and it's ready to be merged

Copy link
Contributor

@fifoosid fifoosid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge the master branch in order to fix the failing build

@nnaydenow nnaydenow requested review from fifoosid and ilhan007 May 27, 2021 11:59
@ilhan007 ilhan007 dismissed fifoosid’s stale review May 28, 2021 07:19

build fixed

@ilhan007 ilhan007 merged commit 42a1326 into SAP:master May 28, 2021
kskondov pushed a commit that referenced this pull request May 31, 2021
Added new property attribute which determines whether the component is displayed as partially checked.

Fixes: #3217
kskondov pushed a commit that referenced this pull request May 31, 2021
Added new property attribute which determines whether the component is displayed as partially checked.

Fixes: #3217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tri-State Check Box feature
3 participants