fix(ui5-upload-collection-item): fixed keyboard navigation #3327
+105
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename on Enter - keep edit mode when focus out - shift+tab on "edit" button doesn't act as it is pressed - when edit and press "esc" button, the focus goes to the "edit" button - editing is working and after pressing "esc" key
the ItemNavigation
georgimkv
previously requested changes
May 28, 2021
There was a problem hiding this comment.
If the focus is on the Edit button of the item, pressing Enter makes it editable, then immediately changes it back to non-editable.
Activating the "Rename" button with Space doesn't do anything. This "Space" press is prevented in ListItem.js in the function _onkeydown. Same for "Cancel".
Run yarn hash and add the changed hash file to the commit.
Link the PR and commit by adding "Part of #3092" to the message
georgimkv
approved these changes
Jun 7, 2021
dimovpetar
approved these changes
Jun 8, 2021
fifoosid
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3092