fix(ui5-dialog): fix text selection on chrome #3532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgimkv
requested review from
dimovpetar,
TeodorTaushanov,
GerganaKremenska and
alexandar-mitsev
dimovpetar
previously requested changes
Jul 23, 2021
fifoosid
reviewed
Jul 26, 2021
WICG/webcomponents#773 On Chrome, clicking on slotted elements (light DOM) in the dialog (shadow DOM) causes the focus to travel up the light DOM tree to reach the closes element that is focusable. Which ends to be the body element as document.activeElement. This is not the case for FF & Safari, where the focus travels up the slot, reaching the dialog root which is actually the closest focusable element. This change introduces a workaround to align the focus behaviour in Chrome with the other browsers. Fixes #3466
georgimkv
force-pushed
the
dialog_text_selection_fix
branch
from
d7e4327 to
b68bfdf
Compare
alexandar-mitsev
previously requested changes
Jul 27, 2021
I couldn't find a way to select text with wdio to test this. Fixed the case for the sample "Open empty dialog (no focusable element)" |
georgimkv
dismissed stale reviews from alexandar-mitsev and dimovpetar
adressed comments
ilhan007
approved these changes
Aug 2, 2021
GerganaKremenska
previously approved these changes
Aug 2, 2021
|
Is the following expected? |
ilhan007
previously requested changes
Aug 2, 2021
ilhan007
previously requested changes
Aug 3, 2021
ilhan007
approved these changes
Aug 3, 2021
ilhan007
pushed a commit
that referenced
this pull request
Aug 3, 2021
On Chrome, clicking on slotted elements (light DOM) in the dialog (shadow DOM) causes the focus to travel up the light DOM tree to reach the closes element that is focusable. Which ends to be the body element as document.activeElement. This is not the case for FF & Safari, where the focus travels up the slot, reaching the dialog root which is actually the closest focusable element. This change introduces a workaround to align the focus behaviour in Chrome with the other browsers. Related issue: WICG/webcomponents#773 Fixes #3466
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Chrome, clicking on slotted elements (light DOM) in the
dialog (shadow DOM) causes the focus to travel up the light DOM tree to
reach the closes element that is focusable.
Which ends to be the body element as document.activeElement.
This is not the case for FF & Safari, where the focus travels up the
slot, reaching the dialog root which is actually the closest focusable element.
This change introduces a workaround to align the focus behaviour in Chrome
with the other browsers.
Related issue: WICG/webcomponents#773
Fixes #3466