-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-carousel): Implement F7 keyboard functionality #3559
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On http://localhost:8080/test-resources/pages/Carousel.html
If the focus is on a list item within a card, pressing F7 twice will not restore the focus to the same item.
_onfocusin in the Carousel does not get called every time - in particular, when the focus moves from the card header to the list in the card.
Can you also write a test?
fa59a1e
to
1f992a3
Compare
Tests are added. The ui5-list stops propagation of the "focusin" event. For that F7 keyboard navigation doesn't work for it. This should be fixed in the ui5-list. |
+1, someone from @SAP/ui5-webcomponents-topic-rd should also review the change |
If this was the last change related to the Keyboard Handling epic, you can close the issue |
Part of #3092