fix(ui5-avatar): Fixed font-size and color-scheme #3799
Merged
+60
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnaydenow
previously requested changes
Sep 2, 2021
ilhan007
reviewed
Sep 14, 2021
| @@ -1,5 +1,6 @@ | |||
| @import "../base/sizes-parameters.css"; | |||
| @import "../base/Avatar-parameters.css"; | |||
ilhan007
reviewed
Sep 14, 2021
…ui5-webcomponents into fix-avatar-fontsize-color-2
…ui5-webcomponents into fix-avatar-fontsize-color-2
|
Hi @ilhan007, For me it's look okey. |
ilhan007
reviewed
Oct 5, 2021
| @@ -0,0 +1,7 @@ | |||
| :root { | |||
There was a problem hiding this comment.
The Convention that is currently in use is: here in sap_fiori_3_dark/Avatar-parameters.css
we import the base params
@import "../base/Avatar-parameters.css";
and then in sap_fiori_3_dark/parameters-bundle.css leave only the theme specific import
@import "./Avatar-parameters.css";
and removing @import "../base/Avatar-parameters.css"; from sap_fiori_3_dark/parameters-bundle.css
as it will be imported above
And this applies for all the themes that you introduce a theme specific params file (as sap_fiori_3_dark/Avatar-parameters.css )
The way you did it, it works as well, but it's not consistent will all the other components params.
ilhan007
approved these changes
Oct 8, 2021
|
+1 from my side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.