feat(ui5-product-switch): Selected state added to an item #3872
+40
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com/SAP/ui5-webcomponents into add-selected-state-ProductSwitchItem
…o add-selected-state-ProductSwitchItem
ilhan007
reviewed
Sep 14, 2021
packages/fiori/src/ProductSwitch.js
Outdated
| @@ -156,6 +156,13 @@ class ProductSwitch extends UI5Element { | |||
| } | |||
| } | |||
|
|
|||
| handleProductSwitchItemClick(event) { | |||
| event.target.parentNode.querySelectorAll("ui5-product-switch-item").forEach(item => { | |||
There was a problem hiding this comment.
To get the ProductSwitch items, you just need to use "this.items" and this will become
this.items.forEach(item => { item.selected = false;});
There was a problem hiding this comment.
Should not this behaviour also happen on SPACE/ENTER?
nnaydenow
reviewed
Sep 15, 2021
| @@ -26,6 +26,7 @@ | |||
| #individual-pop .avatar-slot, | |||
| #groupPop .avatar-slot { | |||
| display: inline-block; | |||
| vertical-align: middle; | |||
There was a problem hiding this comment.
seems to be not related to this change
|
Shift + Space should not change the selection. Selected item should have --sapList_Hover_SelectionBackground background color when it is hovered. |
ilhan007
previously approved these changes
Sep 20, 2021
ilhan007
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now ui5-product-switch-item recieves a selected state on click or keydown, which is unique for an ui5-product-switch collection