Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-upload-collection): Added "accessibleName" property #3917

Merged
merged 5 commits into from
Sep 14, 2021
Merged

feat(ui5-upload-collection): Added "accessibleName" property #3917

merged 5 commits into from
Sep 14, 2021

Conversation

TeodorTaushanov
Copy link
Member

Fix #3768

@TeodorTaushanov TeodorTaushanov requested a review from a team September 13, 2021 13:43
dimovpetar
dimovpetar previously requested changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@dimovpetar dimovpetar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. I would consult with Gery.

packages/fiori/src/UploadCollection.hbs Outdated Show resolved Hide resolved
packages/fiori/src/UploadCollection.hbs Show resolved Hide resolved
@TeodorTaushanov TeodorTaushanov requested review from a team and dimovpetar September 14, 2021 09:04
dimovpetar
dimovpetar requested changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@dimovpetar dimovpetar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider to mark the commit as feat for adding accessibleName property

packages/fiori/src/UploadCollection.js Outdated Show resolved Hide resolved
@TeodorTaushanov TeodorTaushanov changed the title fix(ui5-upload-collection): Fixed header screen reading feat(ui5-upload-collection): Added "accessibleName" property Sep 14, 2021
@ilhan007 ilhan007 merged commit ea79fb3 into master Sep 14, 2021
@ilhan007 ilhan007 deleted the UploadCollectionGroupLabel branch September 14, 2021 12:07
ilhan007 pushed a commit that referenced this pull request Sep 16, 2021
@TeodorTaushanov @ilhan007
feat(ui5-upload-collection): Added "accessibleName" property (#3917)
7cb8e04 
Fixes:  #3768
Closes:  #3768
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimovpetar dimovpetar dimovpetar approved these changes

@ilhan007 ilhan007 Awaiting requested review from ilhan007

@fifoosid fifoosid Awaiting requested review from fifoosid

Assignees
No one assigned
Labels
SAP SF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SF][A11y][UploadCollection]: Cannot set the group label for the UploadCollection
3 participants
@TeodorTaushanov @dimovpetar @ilhan007