Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-multi-combobox): prefilter selected items on n more click #3931

Merged
merged 11 commits into from
Sep 27, 2021

Conversation

MapTo0
Copy link
Member

@MapTo0 MapTo0 commented Sep 15, 2021

FIXES: #3639, #3640, #3761, #3762

packages/main/test/specs/MultiComboBox.spec.js Outdated Show resolved Hide resolved
packages/main/src/MultiComboBox.js Show resolved Hide resolved
Copy link
Contributor

@niyap niyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open the test page on mobile device and check the first sample. Open the N-more popover, deselect an item via its checkbox, press the filter selected items button in order to make visible all suggestions, then press it again - the unselected item is still visible in the selected items. It should be removed, when filtered again.

Copy link
Contributor

@niyap niyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open the test page on mobile. Check the second sample, where there are predefined value. If you press the N-more indicator, the predefined value is forwarded to the dialog's input and the items are filtered. On the other hand, if you tap over the predefined value, in the input field or the arrow down icon, the behaviour is different - the value is not forwarded to the inner input, the items are not filtered as well as, when the dialog is closed, the predefined value is cleared.
Another issue found: For example check the first sample in the test page on mobile device. Open the dialog via the icon or via tap in the inout field. Selected all the items, press Ok and close the dialog. Then open the dialog again, no matter how. You can notice how all the items are selected and the filter button is disabled, deselect an item via its checkbox - the filter button is still disabled, which I think that is not correct because in that moment, the filtered items are different from the list with all the items.

remove disabling of toggle button on mobile
Copy link
Contributor

@niyap niyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you try to delete a token via its clear icon, the dialog is always open, where the item is already deselected and no matter pressing cancel or ok button, it is deleted. In UI5 it is immediately deleted without opening the dialog.

Also, check the first sample of the test page on mobile. Tap over the 1more, tap over the filter button in order to see all suggestion, select the unselected one and press OK button. Then tap over the 2more, when the dialog is open deselect one item then tap over the filter button in order to see just the selected ones - the items are not filtered, no matter how many times you tap over the filter button all suggestions are presented both when you select to visualised all the items and just the filtered one.

Copy link
Contributor

@niyap niyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing, when we have MultiComboBox with allowCustomValues set to true. On mobile, if the value is changed from the input within the dialog and then cancel button is pressed, the value is changed instead of cancel the changes.

niyap
niyap previously approved these changes Sep 24, 2021
Copy link
Contributor

@niyap niyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, if you check the sample "Validating input and predefined value" (multicombobox with allowCustomValue set to true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiComboBox on mobile, button is not working
3 participants