fix(ui5-shellbar): remove unnecessary aria-label from buttons #3981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ui5-button component used inside ui5-shellbar have both aria-label and title set with the same value. This may lead to double announcement and trigger warrning by test tools. With this change we remove the aria-label attribute from the ui5-buttons. Fixes: SAP#3953
dobrinyonkov
requested review from
ilhan007,
fifoosid,
PetyaMarkovaBogdanova and
nnaydenow
nnaydenow
approved these changes
Sep 23, 2021
ilhan007
approved these changes
Sep 23, 2021
ilhan007
pushed a commit
that referenced
this pull request
Sep 23, 2021
The ui5-button component used inside ui5-shellbar have both aria-label and title set with the same value. This may lead to double announcement and trigger warrning by test tools. With this change we remove the aria-label attribute from the ui5-buttons. Fixes: #3953
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ui5-buttoncomponents used insideui5-shellbarhave botharia-labelandtitleattributes set with the same value. This may lead to double announcementand trigger warnings by test tools. With this change we remove the
aria-labelattribute.Fixes: #3953