Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-segmented-button): implement sap_horizon theme #4197

Merged
merged 17 commits into from
Nov 1, 2021
Merged

feat(ui5-segmented-button): implement sap_horizon theme #4197

merged 17 commits into from
Nov 1, 2021

Conversation

terezamch
Copy link
Contributor

No description provided.

tsanislavgatev
tsanislavgatev requested changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@tsanislavgatev tsanislavgatev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On horizon when item is selected, the text of the item is moving.
On fiori_3, there is a small difference between master and this branch sizing of the whole segmented button

@tsanislavgatev tsanislavgatev self-requested a review November 1, 2021 13:04
tsanislavgatev
tsanislavgatev approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@tsanislavgatev tsanislavgatev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ilhan007 ilhan007 merged commit 33d0f60 into SAP:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsanislavgatev tsanislavgatev tsanislavgatev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terezamch @tsanislavgatev @ilhan007