fix(ui5-table): adjust header row's height according to the visual specification #4424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MapTo0
previously approved these changes
Dec 6, 2021
fifoosid
reviewed
Dec 6, 2021
| @@ -287,6 +287,7 @@ | |||
| --_ui5_load_more_text_height: 2.625rem; | |||
| --_ui5_load_more_text_font_size: var(--sapFontSize); | |||
| --_ui5_load_more_desc_padding: 0 2rem 0.875rem 2rem; | |||
| --ui5_table_header_row_height: 2rem; | |||
There was a problem hiding this comment.
In this file, the default values for sap_fiori_3 theme are stored. So I think here it should be 2.75rem. And for the theme where you need it to be 2rem, you should add it in the corresponding file
There was a problem hiding this comment.
That is the corresponding value for compact density which is the same for all supported themes.
fifoosid
approved these changes
Dec 7, 2021
eshpak
pushed a commit
to eshpak/ui5-webcomponents
that referenced
this pull request
Jan 9, 2022
…ecification (SAP#4424) * fix(ui5-table): adjust header row's height according to the visual specification * correctly define parameter values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES: #4398