fix(ui5-table): check select all checkbox, when all rows are selected programatically #4455
+34
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elenastoyanovaa
requested changes
Dec 9, 2021
| @@ -371,6 +371,29 @@ describe("Table general interaction", () => { | |||
| assert.strictEqual(await selectionChangeCount.getProperty("value"), "5", "Enter key over an already selected row should trigger selection-change event"); | |||
| }); | |||
|
|
|||
| it("test selectAll functionallity in MultiSelect mode", async () => { | |||
There was a problem hiding this comment.
could you also add a case, when the checkbox is checked, then you have unselected an item.
elenastoyanovaa
approved these changes
Dec 9, 2021
eshpak
pushed a commit
to eshpak/ui5-webcomponents
that referenced
this pull request
Jan 9, 2022
… programatically (SAP#4455) * fix(ui5-table): check select all checkbox, when all rows are selected programatically * remove change added by mistake * additional test added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES: #4338