feat(ui5-combobox): add full keyboard handling #4494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3xter666
previously approved these changes
Dec 21, 2021
fifoosid
suggested changes
Dec 21, 2021
simonarangelova
suggested changes
Jan 5, 2022
ndeshev
reviewed
Jan 10, 2022
|
[ALT]+[UP]/[DOWN],[F4] issues with the focus on open and text selection on close remain |
ndeshev
reviewed
Jan 11, 2022
There was a problem hiding this comment.
When F4 or Alt+Arr is used to open the picker the focus should go to the first item (and it should also be selected), it works only if there is not a value state present. If it is - the value state is focused, which is wrong.
Otherwise the changes looks fine.
ndeshev
approved these changes
Jan 14, 2022
fifoosid
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keyboard specification for the ComboBox is now fully implemented, with the addition of the following keys:
F4,ALT+UP/DOWN- Toggles the picker.PAGEDOWN- Moves selection down by page size (10 items by default).PAGEUP- Moves selection up by page size (10 items by default).HOME- If focus is in the ComboBox, moves cursor at the beginning of text. If focus is in the picker, selects the first item.END- If focus is in the ComboBox, moves cursor at the end of text. If focus is in the picker, selects the last item.Related to: #3090