Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-popup): add accessibleNameRef property #4517

Merged
merged 2 commits into from
Jan 4, 2022
Merged

feat(ui5-popup): add accessibleNameRef property #4517

merged 2 commits into from
Jan 4, 2022
+85 −28

Conversation

dimovpetar
Copy link
Contributor

Affects Dialog, Popover and ResponsivePopover.

@dimovpetar
feat(ui5-popup): add accessibleNameRef property
649e241 
Affects Dialog, Popover and ResponsivePopover.
@dimovpetar dimovpetar requested a review from a team December 21, 2021 16:18
fifoosid
fifoosid suggested changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@fifoosid fifoosid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, it might be a good idea to add a test for the responsive popover as well

packages/main/src/Popup.js Outdated Show resolved Hide resolved
packages/main/src/Popup.js Outdated Show resolved Hide resolved
@dimovpetar
Copy link
Contributor Author

If possible, it might be a good idea to add a test for the responsive popover as well

Couldn't find a way to mock phone. The desktop part is already covered

@dimovpetar dimovpetar requested a review from fifoosid December 22, 2021 15:57
@fifoosid fifoosid merged commit 0a7c1f3 into master Jan 4, 2022
@fifoosid fifoosid deleted the feat_popup_accnameref branch January 4, 2022 13:39
eshpak pushed a commit to eshpak/ui5-webcomponents that referenced this pull request Jan 9, 2022
@dimovpetar @eshpak
feat(ui5-popup): add accessibleNameRef property (SAP#4517)
5021d3f
@GerganaKremenska GerganaKremenska mentioned this pull request Mar 11, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fifoosid fifoosid fifoosid approved these changes

@GerganaKremenska GerganaKremenska GerganaKremenska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dimovpetar @fifoosid @GerganaKremenska