Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(framework): Tabbable elements error #4704

Merged
merged 1 commit into from
Feb 7, 2022
Merged

fix(framework): Tabbable elements error #4704

merged 1 commit into from
Feb 7, 2022

Conversation

vladitasev
Copy link
Contributor

@vladitasev vladitasev commented Feb 7, 2022 •
edited
Loading

The code in TabbableElements.js may throw an error, if the shadow root is empty, because currentNode will be undefined and then the following code will be executed:

if (currentNode.tagName === "SLOT") {

@vladitasev vladitasev merged commit 650473f into master Feb 7, 2022
@vladitasev vladitasev deleted the fix-tabbable-error branch February 7, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

@fifoosid fifoosid fifoosid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladitasev @ilhan007 @fifoosid