Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-input): aria-invalid is now properly rendered #4734

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

hristop
Copy link
Contributor

@hristop hristop commented Feb 11, 2022

The attribute aria-invalid="true" is now fully rendered, as otherwise, it will not be announced by JAWS screen reader.

Fixes #4723

The attribute is bulean, however, it is now anounced by
JAWS in case it is not rendered as aria-invalid="true"

Fixes #4723
@hristop hristop requested a review from niyap February 11, 2022 12:05
Copy link
Contributor

@niyap niyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test, because the scenario was not tested to that moment.

@hristop hristop merged commit 81a00d7 into master Feb 14, 2022
@ilhan007 ilhan007 deleted the input-aria-invalid branch February 14, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SF][A11y][Input] aria-invalid issue
3 participants