fix(framework): add more 72-* fonts as system styles #4934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fifoosid
approved these changes
Mar 22, 2022
vladitasev
approved these changes
Mar 22, 2022
ilhan007
added a commit
that referenced
this pull request
Mar 22, 2022
The **72-Bold** font did not apply correctly on stakeholder side in FireFox (see the linked issue for more information.). This can be also reproduced in our test pages by opening the Card test page **in sap_horizon in FireFox** via this [link](https://sap.github.io/ui5-webcomponents/master/playground/main/pages/Card/?sap-ui-theme=sap_horizon). The headings in the Card header should have been bold, however they appear normal instead. The insertion of the **72-Bold, '72-Boldfull', '72-Light' and '72-Lightfull'** fonts explicitly as part of the system vars seem to resolve the issue. The changes is adding the ones that are missing, compared to OpenUi5. FIXES #4931
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The 72-Bold font did not apply correctly on stakeholder side in FireFox (see the linked issue for more information.).
This can be also reproduced in our test pages by opening the Card test page in sap_horizon in FireFox via this link.
The headings in the Card header should have been bold, however they appear normal instead. I
In Chrome the issue is not reproducible, probably because of difference in the font loading.
Solution
The insertion of the 72-Bold, '72-Boldfull', '72-Light' and '72-Lightfull' fonts explicitly as part of the system vars
seem to resolve the issue. The changes is adding the ones that are missing, compared to OpenUi5
FIXES #4931