Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-message-strip): apply SAP Horizon parameters #4941

Merged
merged 2 commits into from
Mar 28, 2022
Merged

feat(ui5-message-strip): apply SAP Horizon parameters #4941

merged 2 commits into from
Mar 28, 2022

Conversation

stbodurov
Copy link
Contributor

@stbodurov stbodurov commented Mar 22, 2022 •
edited by ilhan007
Loading

Related to: #5007

@cla-assistant
Copy link

cla-assistant bot commented Mar 22, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@stbodurov stbodurov requested a review from ivoplashkov March 22, 2022 12:27
@stbodurov stbodurov marked this pull request as draft March 22, 2022 14:59
@stbodurov stbodurov marked this pull request as ready for review March 22, 2022 19:35
ivoplashkov
ivoplashkov requested changes Mar 23, 2022
View reviewed changes
Copy link
Member

@ivoplashkov ivoplashkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
At first glance the border color for the messagestrip with states seems to be incorrect in all themes.
Also the border radius seems to be incorrect.

Screenshot 2022-03-23 at 2 07 34

ivoplashkov
ivoplashkov requested changes Mar 23, 2022
View reviewed changes
Copy link
Member

@ivoplashkov ivoplashkov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like I haven't installed the new dependencies, that's why the parameters didn't resolve correctly, therefore disregard my previous comment.

I saw a misalignment ( seems to be a little more to the top ) in the HC themes for the messagestrip button, could you please check?

Screenshot 2022-03-23 at 10 01 31

@stbodurov stbodurov requested a review from ivoplashkov March 23, 2022 14:57
@stbodurov
Copy link
Contributor Author

Seems like I haven't installed the new dependencies, that's why the parameters didn't resolve correctly, therefore disregard my previous comment.

I saw a misalignment ( seems to be a little more to the top ) in the HC themes for the messagestrip button, could you please check?

Screenshot 2022-03-23 at 10 01 31

Done

@stbodurov stbodurov merged commit 8919965 into SAP:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivoplashkov ivoplashkov ivoplashkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stbodurov @ivoplashkov