Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-notification-list-item): focus is no longer trapped in loading item #8969

Merged
merged 15 commits into from
Jul 8, 2024

Conversation

dimovpetar
Copy link
Contributor

Fixes #8768

@github-actions github-actions bot added the Stale label Jun 6, 2024
@github-actions github-actions bot closed this Jun 13, 2024
@dimovpetar dimovpetar reopened this Jun 17, 2024
@github-actions github-actions bot removed the Stale label Jun 18, 2024
@BorisDafov
Copy link

I approve the PR from UA perspective

@dimovpetar dimovpetar force-pushed the busy_notification_focus branch from 8e47f79 to b6bb5b6 Compare July 8, 2024 08:58
Copy link
Member

@TeodorTaushanov TeodorTaushanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"arrow" navigation in fiori/test/pages/NotificationListItem.html doesn't work correctly.

@dimovpetar
Copy link
Contributor Author

NotificationListItem.html

added title before every list in the test page to make it clear that those are separate lists

@dimovpetar dimovpetar merged commit fa37d92 into main Jul 8, 2024
10 checks passed
@dimovpetar dimovpetar deleted the busy_notification_focus branch July 8, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui5-li-notification-group]: Focus is trapped
3 participants