-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui5-menu): restore focus to the opener #9041
Conversation
- The focus is restored over the opener element after root menu close. - Redudant icon dependency is removed from the menu.
The |
Test looks good to me but I haven’t review the rest of PR. |
Merge main into your branch to get the change that makes the tests stable. |
…to menu_additional_improvements
Test is failing because following code doesn't work and the focus is not restored to the button when the menu is closed.
|
Tested manually with latest and the fix does not work as expected in the github issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussion and additional test we've came to the conclusion that the latest version works as expected and described in the issue.
ui5-menu-item
.start-section
property usage is replaced with theui5-menu-separator
component usage.Fixes: #9317