feat: add animationMode configuration #905
Merged
+112
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add animationMode to configure the degree of components animations. Available options are: 'full' (by default), 'basic', 'minimal', 'none'. - switch on/off the ui5-panel toggle animation based on the 'animationMode'
3 tasks
vladitasev
requested changes
Nov 11, 2019
| @@ -0,0 +1,7 @@ | |||
| const AnimationModes = { | |||
There was a problem hiding this comment.
Should be AnimationMode (not modes), similar to ButtonType.
vladitasev
requested changes
Nov 11, 2019
docs/Configuration.md
Outdated
| @@ -11,6 +11,7 @@ theme | sap_fiori_3, sap_belize, sap_belize_hcb | sap_fiori_3 | | |||
| language | en, de, es, etc... | en | Language to be used for translatable texts | |||
| [RTL](#rtl) | true, false | false | When true, sets global text direction to right-to-left | |||
| compactSize | true, false | false | When set, enforces compact density (smaller margins/paddings) | |||
| [animationMode](#animationMode) | full, basic, minimal, none | false | Defines the animation effects of the web components | |||
vladitasev
approved these changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
animationModeto configure the degree of components animations.Available options are:
full(by default),basic,minimalandnone,where
fullmeans all animations run without restrictions andnonemeans all animations are off.animationMode.