Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-input, ui5-combobox, ui5-multi-combobox): prevent native input autocomplete #9141

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

niyap
Copy link
Contributor

@niyap niyap commented Jun 6, 2024

Adding autocomplete="off" to input fields is crucial due to security risks, as browsers may store sensitive data locally or in the cloud. Browser-specific implementation create inconsistent and unpredictable user experiences. Varying event handling across browsers can lead to significant functionality issues. UI5 web components already provides effective solutions making browser-based autocomplete unnecessary.

@niyap niyap requested review from ndeshev and nnaydenow June 6, 2024 12:11
@niyap niyap requested a review from ilhan007 June 7, 2024 09:43
@github-actions github-actions bot added the Stale label Jun 29, 2024
@nnaydenow nnaydenow removed the Stale label Jul 2, 2024
@nnaydenow nnaydenow merged commit ddd6314 into release-1.24 Jul 2, 2024
9 checks passed
@nnaydenow nnaydenow deleted the inputsautocompleteoff124 branch July 2, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants