Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-timeline-group-item): introduce new component #9407

Merged
merged 18 commits into from
Aug 2, 2024
Merged

feat(ui5-timeline-group-item): introduce new component #9407

merged 18 commits into from
Aug 2, 2024

Conversation

hinzzx
Copy link
Contributor

@hinzzx hinzzx commented Jul 8, 2024 •
edited
Loading

Introducing the new <ui5-timeline-group-item> web component.

It allows the application developers to group a <ui5-timeline-item>'s under one name, specified by the groupName property.

Mixed scenarios are possible, between <ui5-timeline-item>'s and <ui5-timeline-group-item>'s, where they are on the same level in the DOM.

Sample usage of groups in mixed scenarios could be:

<ui5-timeline id="verticalWithGrps">
    <ui5-timeline-item></ui5-timeline-item>
    <ui5-timeline-item></ui5-timeline-item>
 
    /* Items in a group */
    <ui5-timeline-group-item group-name="Events">

        <ui5-timeline-item>Morning event</ui5-timeline-item>
	<ui5-timeline-item>
	     <ui5-avatar initials="SK"></ui5-avatar>
	     <ui5-label>Good morning</ui5-label>
	</ui5-timeline-item>
	<ui5-timeline-item><ui5-avatar initials="SK"></ui5-avatar></ui5-timeline-item>

    </ui5-timeline-group-item>

    <ui5-timeline-item></ui5-timeline-item>
    <ui5-timeline-item></ui5-timeline-item>
</ui5-timeline>

Vertical layout

2024-07-22_09-36-41

Horizontal layout

2024-07-22_09-43-54

@hinzzx hinzzx marked this pull request as draft July 8, 2024 06:22
Todor-ads
Todor-ads reviewed Jul 18, 2024
View reviewed changes
packages/fiori/src/TimelineGroupItem.ts Outdated Show resolved Hide resolved
packages/fiori/src/TimelineGroupItem.ts Outdated Show resolved Hide resolved
packages/fiori/src/TimelineGroupItem.ts Outdated Show resolved Hide resolved
packages/fiori/src/TimelineItem.ts Outdated Show resolved Hide resolved
packages/fiori/src/Timeline.ts Outdated Show resolved Hide resolved
packages/fiori/src/Timeline.ts Show resolved Hide resolved
packages/fiori/src/Timeline.ts Show resolved Hide resolved
packages/fiori/src/Timeline.ts Show resolved Hide resolved
packages/fiori/src/TimelineGroupItem.ts Outdated Show resolved Hide resolved
tsanislavgatev
tsanislavgatev reviewed Jul 19, 2024
View reviewed changes
packages/fiori/src/Timeline.ts Outdated Show resolved Hide resolved
packages/fiori/src/Timeline.ts Outdated Show resolved Hide resolved
packages/fiori/src/Timeline.ts Outdated Show resolved Hide resolved
packages/fiori/src/Timeline.ts Show resolved Hide resolved
packages/fiori/src/Timeline.ts Show resolved Hide resolved
packages/fiori/src/TimelineGroupItem.ts Outdated Show resolved Hide resolved
packages/fiori/src/TimelineGroupItem.ts Outdated Show resolved Hide resolved
packages/fiori/src/TimelineItem.hbs Outdated Show resolved Hide resolved
packages/fiori/src/TimelineItem.ts Outdated Show resolved Hide resolved
packages/fiori/src/TimelineItem.ts Outdated Show resolved Hide resolved
@hinzzx hinzzx changed the title WIP(ui5-timeline-group-item): introduce new component feat(ui5-timeline-group-item): introduce new component Jul 22, 2024
@hinzzx hinzzx marked this pull request as ready for review July 22, 2024 06:55
Todor-ads
Todor-ads reviewed Jul 22, 2024
View reviewed changes
Copy link
Member

@Todor-ads Todor-ads left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side, the change looks good. Let the colleagues also review this change.

@hinzzx hinzzx requested review from nnaydenow and ilhan007 July 23, 2024 06:56
nnaydenow
nnaydenow requested changes Jul 23, 2024
View reviewed changes
packages/fiori/src/Timeline.ts Outdated Show resolved Hide resolved
packages/fiori/src/TimelineGroupItem.ts Outdated Show resolved Hide resolved
packages/fiori/src/TimelineGroupItem.ts Outdated Show resolved Hide resolved
packages/fiori/src/TimelineGroupItem.ts Show resolved Hide resolved
packages/fiori/src/TimelineItem.ts Outdated Show resolved Hide resolved
packages/fiori/src/TimelineItem.ts Outdated Show resolved Hide resolved
packages/fiori/src/TimelineItem.ts Outdated Show resolved Hide resolved
packages/fiori/src/TimelineItem.hbs Outdated Show resolved Hide resolved
@hinzzx hinzzx requested a review from nnaydenow July 26, 2024 06:29
nnaydenow
nnaydenow previously requested changes Jul 31, 2024
View reviewed changes
packages/fiori/src/Timeline.ts Show resolved Hide resolved
packages/fiori/src/Timeline.ts Outdated Show resolved Hide resolved
packages/fiori/src/TimelineGroupItem.ts Show resolved Hide resolved
packages/fiori/src/TimelineGroupItem.ts Outdated Show resolved Hide resolved
packages/fiori/src/TimelineGroupItem.ts Outdated Show resolved Hide resolved
packages/fiori/src/TimelineGroupItem.ts Outdated Show resolved Hide resolved
packages/fiori/src/TimelineItem.ts Outdated Show resolved Hide resolved
packages/fiori/src/TimelineItem.ts Outdated Show resolved Hide resolved
nnaydenow
nnaydenow reviewed Jul 31, 2024
View reviewed changes
Copy link
Contributor

@nnaydenow nnaydenow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from API perspective looks fine

@nnaydenow nnaydenow dismissed their stale review July 31, 2024 13:09

from API perspective looks fine

@hinzzx hinzzx merged commit aea62ef into main Aug 2, 2024
10 checks passed
@hinzzx hinzzx deleted the feat-tl-group-item branch August 2, 2024 06:11
@tsanislavgatev
Copy link
Contributor

fixes: #7855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnaydenow nnaydenow nnaydenow left review comments

@Todor-ads Todor-ads Todor-ads left review comments

@tsanislavgatev tsanislavgatev tsanislavgatev approved these changes

@ilhan007 ilhan007 Awaiting requested review from ilhan007

Assignees
No one assigned
Labels
for review New Component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hinzzx @tsanislavgatev @Todor-ads @nnaydenow