fix(ui5-toolbar): update ToolbarRegistry to use metadata tag instead of class name #9607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dobrinyonkov
force-pushed
the
toolbar-registry-tagname
branch
from
8ec711e to
1e96319
Compare
plamenivanov91
approved these changes
Aug 1, 2024
dobrinyonkov
added a commit
that referenced
this pull request
Aug 5, 2024
…of class name (#9607) This change updates the registration mechanism for toolbar items to use a metadata tag instead of the class name. #### Changes: - In `Toolbar.ts`, updated the `getItemsInfo` method to retrieve the registered toolbar item using `ctor.getMetadata().getPureTag()` instead of `item.constructor.name`. - In `ToolbarRegistry.ts`, modified the `registerToolbarItem` function to register items with `ElementClass.getMetadata().getPureTag()` instead of `ElementClass.name`. #### Issue Addressed: In production builds, webpack minifies class names which resulted in all toolbar buttons being registered under the same name ("i"). This caused all toolbar items to be registered as the last one registered due to name conflicts. By switching to a more stable identifier from the class metadata, we prevent such issues.
dobrinyonkov
added a commit
that referenced
this pull request
Aug 6, 2024
#9638) This change updates the registration mechanism for toolbar items to use a metadata tag instead of the class name. Changes: In Toolbar.ts, updated the getItemsInfo method to retrieve the registered toolbar item using ctor.getMetadata().getPureTag() instead of item.constructor.name. In ToolbarRegistry.ts, modified the registerToolbarItem function to register items with ElementClass.getMetadata().getPureTag() instead of ElementClass.name. Issue Addressed: In production builds, webpack minifies class names which resulted in all toolbar buttons being registered under the same name ("i"). This caused all toolbar items to be registered as the last one registered due to name conflicts. By switching to a more stable identifier from the class metadata, we prevent such issues. Related to: #9607
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the registration mechanism for toolbar items to use a metadata tag instead of the class name.
Changes:
Toolbar.ts, updated thegetItemsInfomethod to retrieve the registered toolbar item usingctor.getMetadata().getPureTag()instead ofitem.constructor.name.ToolbarRegistry.ts, modified theregisterToolbarItemfunction to register items withElementClass.getMetadata().getPureTag()instead ofElementClass.name.Issue Addressed:
In production builds, webpack minifies class names which resulted in all toolbar buttons being registered under the same name ("i"). This caused all toolbar items to be registered as the last one registered due to name conflicts. By switching to a more stable identifier from the class metadata, we prevent such issues.