From 357ef4c39656aec80934ad8f71e7e1837b8487cc Mon Sep 17 00:00:00 2001 From: Martin Hristov Date: Tue, 2 Jul 2019 14:20:16 +0300 Subject: [PATCH] refactor(ui5-shellbar-item): Rename press event to itemClick BREAKING CHANGE: ui5-shellbar-item press event is renamed to itemClick --- packages/main/src/ShellBar.js | 2 +- packages/main/src/ShellBarItem.js | 2 +- .../main/test/sap/ui/webcomponents/main/pages/ShellBar.html | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/main/src/ShellBar.js b/packages/main/src/ShellBar.js index 7559c8d325ff..007fb280eb0e 100644 --- a/packages/main/src/ShellBar.js +++ b/packages/main/src/ShellBar.js @@ -680,7 +680,7 @@ class ShellBar extends UI5Element { return item.shadowRoot.querySelector(`#${refItemId}`); })[0]; - const prevented = !shellbarItem.fireEvent("press", { targetRef: event.target }, true); + const prevented = !shellbarItem.fireEvent("itemClick", { targetRef: event.target }, true); this._defaultItemPressPrevented = prevented; } diff --git a/packages/main/src/ShellBarItem.js b/packages/main/src/ShellBarItem.js index 52b14410cce9..f30b4a36a81d 100644 --- a/packages/main/src/ShellBarItem.js +++ b/packages/main/src/ShellBarItem.js @@ -40,7 +40,7 @@ const metadata = { * @param {HTMLElement} targetRef dom ref of the clicked element * @public */ - press: { + itemClick: { detail: { targetRef: { type: HTMLElement }, }, diff --git a/packages/main/test/sap/ui/webcomponents/main/pages/ShellBar.html b/packages/main/test/sap/ui/webcomponents/main/pages/ShellBar.html index 76088aadcfd8..70d366321f73 100644 --- a/packages/main/test/sap/ui/webcomponents/main/pages/ShellBar.html +++ b/packages/main/test/sap/ui/webcomponents/main/pages/ShellBar.html @@ -196,7 +196,7 @@ }); ["disc", "call"].forEach(function(id) { - window[id].addEventListener("ui5-press", function(event) { + window[id].addEventListener("ui5-itemClick", function(event) { event.preventDefault(); window["press-input"].value = event.target.id; window["custom-item-popover"].openBy(event.detail.targetRef);