From 143043b2475666d80fb7365c53bb47c168cf0676 Mon Sep 17 00:00:00 2001 From: Nikolay Hristov Date: Thu, 25 Apr 2024 13:50:29 +0300 Subject: [PATCH 1/2] fix(ui5-time-picker): fix buttons announcements in value help dialog --- packages/main/src/ToggleSpinButton.ts | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/packages/main/src/ToggleSpinButton.ts b/packages/main/src/ToggleSpinButton.ts index 0f62900d9ef5..c1ad16c9af9d 100644 --- a/packages/main/src/ToggleSpinButton.ts +++ b/packages/main/src/ToggleSpinButton.ts @@ -62,6 +62,13 @@ class ToggleSpinButton extends ToggleButton { * Override of the handler in order to prevent button toggle functionality */ _onclick() {} + + /** + * Override of the getter in order to set proper role to the button + */ + get buttonAccessibleRole() { + return "spinbutton"; + } } ToggleSpinButton.define(); From b7e25e690d8e726807f4dc6706f0bd5eee696b0b Mon Sep 17 00:00:00 2001 From: Nikolay Hristov Date: Mon, 29 Apr 2024 14:09:07 +0300 Subject: [PATCH 2/2] fix(ui5-time-picker): fix comments --- packages/main/src/ToggleSpinButton.hbs | 1 - packages/main/src/ToggleSpinButton.ts | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/main/src/ToggleSpinButton.hbs b/packages/main/src/ToggleSpinButton.hbs index ca49b0a856d7..1b8d8f4d34bc 100644 --- a/packages/main/src/ToggleSpinButton.hbs +++ b/packages/main/src/ToggleSpinButton.hbs @@ -6,5 +6,4 @@ aria-valuemax="{{valueMax}}" aria-valuenow="{{valueNow}}" aria-valuetext="{{valueText}}" - role="spinbutton" {{/inline}} diff --git a/packages/main/src/ToggleSpinButton.ts b/packages/main/src/ToggleSpinButton.ts index c1ad16c9af9d..2d3ca33c3ace 100644 --- a/packages/main/src/ToggleSpinButton.ts +++ b/packages/main/src/ToggleSpinButton.ts @@ -64,7 +64,7 @@ class ToggleSpinButton extends ToggleButton { _onclick() {} /** - * Override of the getter in order to set proper role to the button + * Override */ get buttonAccessibleRole() { return "spinbutton";