Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bandit #26

Closed
lyn-cork opened this issue Oct 18, 2023 · 1 comment
Closed

Bandit #26

lyn-cork opened this issue Oct 18, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@lyn-cork
Copy link
Collaborator

lyn-cork commented Oct 18, 2023

Individuals who prey on merchants and other travelers. They lurk in the forest outside of towns where they can quickly attack and escape. Capable of using a mix of range and melee weapons.

@josemvidal
Copy link
Member

This feature appears to be implemented. Why is this still open?

After you do and Issue, you close it, with a comment that points to the commit that closes it. In GitHub you can do this automatically by just writing "closes #xx" in the git-commit comment.

Please watch my teamwork lecture which explains all this an more.
Tip: When you close an issue by writing code, either fixing a bug or creating a new feature, you should add a link to the git-commit(s) that did it.

This can be done automatically if you just write "closes #X" in the comment of the git-commit or the pull request, where X is the issue number you want to close. See linking pull requests to issues using keywords for more information, or watch this video.

You should also write "#X" on any commit that is for #X. That commit will then get automatically linked to the Issue.

See my github tips list for all the tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants