Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDS Standards - Empty List #44

Closed
JodieM opened this issue Oct 19, 2022 · 3 comments
Closed

LDS Standards - Empty List #44

JodieM opened this issue Oct 19, 2022 · 3 comments
Assignees
Labels
c-indicators code discussion in development Actively being worked on and in development

Comments

@JodieM
Copy link
Contributor

JodieM commented Oct 19, 2022

We need to conform to the LWC Standards eg for Empty Lists to use an illustration to show that there is an empty list.
This would be if they add the Component to the Page, choose a CMDT record to use, and that CMDT record has no Indicator records assigned to it yet.
The images are only available as SVGs
There is this repo that makes it easier to add an illustration image to the LWC, but it may not be suitable for packaging

@JodieM JodieM added the code label Oct 19, 2022
@JodieM JodieM changed the title LWC Standards LWC Standards - Empty List Oct 19, 2022
@JodieM JodieM changed the title LWC Standards - Empty List LDS Standards - Empty List Oct 19, 2022
@JodieM
Copy link
Contributor Author

JodieM commented Nov 13, 2022

OK, this is fabulous, but it leaves us with some unintended consequences of #65 not working fully.

So, I am pretty sure these icons can be shown on the Edit mode of the Lightning Record Page only.

So the steps should be:

  • Any Bundle is visible in the Drop Down List.
  • Inactive Bundles show the Empty List Icon in Edit Mode of the Lightning Record Page
  • Inactive Bundles do not render the component at all on the Lightning Record Page

So a bundle can be added to a page, and set up ready to go, and then activated, and it will appear for the users.
And conversely a bundle can be visible, and then made inactive, and it will not show to the users, but it will show the Empty List icon to the Admins in Edit Mode.

@JodieM JodieM assigned tschug and unassigned RevathiSaran Nov 13, 2022
@JodieM
Copy link
Contributor Author

JodieM commented Oct 8, 2023

This is an example of how an empty component shows in Salesforce. The image we have is fine but the sizing should be more like this one.
Snag_1afc3aa7

@JodieM
Copy link
Contributor Author

JodieM commented Nov 8, 2023

Fixed in feature/contains-equals

@tschug tschug added in development Actively being worked on and in development and removed oct23-sprint labels Dec 2, 2023
@tschug tschug closed this as completed Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-indicators code discussion in development Actively being worked on and in development
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants