Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadeploy runs _init_options twice #3504

Open
yippie opened this issue Mar 14, 2023 · 0 comments
Open

Metadeploy runs _init_options twice #3504

yippie opened this issue Mar 14, 2023 · 0 comments

Comments

@yippie
Copy link

yippie commented Mar 14, 2023

When publishing plans, each tasks _init_options ends up getting run twice.

The metadeploy_publish task appears to be running _init_options before upload and then saving the modified options as the options for each step on the new upload. Then, when a user runs a plan through Metadeploy, _init_options runs again, this time starting with the already modified options.

This becomes a big problem if _init_options ever modifies the option values provided in the original flow. This is currently breaking the retrieve_unpackaged task because it is overwriting the package_xml option which is supposed to have a file path, with the file content. This means Metadeploy attempts to retrieve a file from a completely non-sensical file path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant