Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some CSFML 2.6.x API Discrepancies #235

Closed
Marioalexsan opened this issue Feb 26, 2024 · 2 comments
Closed

Some CSFML 2.6.x API Discrepancies #235

Marioalexsan opened this issue Feb 26, 2024 · 2 comments
Labels
Milestone

Comments

@Marioalexsan
Copy link
Member

I've noticed these while trying to update SFML.Net to 2.6.0.

  • Mouse is missing position getters / setters for WindowBase (i.e. sfMouse_getPositionWindowBase and sfMouse_setPositionWindowBase)
  • Touch is missing position getter for WindowBase (i.e. sfTouch_getPositionWindowBase)
  • While it might not be very useful, createVulkanSurface overloads for derived windows are missing (i.e. sfRenderWindow_createVulkanSurface and sfWindow_createVulkanSurface)
  • sfKeyboard_getDescription returns an owning const char* that must be freed using C's free, however CSFML doesn't expose something like sfFree / sfMalloc that can be easily called from the C# side, which causes issues with memory leaks
@ChrisThrasher
Copy link
Member

Thanks for catching these oversights! Looks like a lot of them are due to me not realizing the true extent to which we'd have to change things while adding sf::WindowBase support. We'll get around to fixing these things. Expect them to ship in 2.6.1. Can't provide any estimated timeline yet for when that will ship.

@Marioalexsan
Copy link
Member Author

Closing since it was fixed by #236.

@eXpl0it3r eXpl0it3r linked a pull request May 20, 2024 that will close this issue
@eXpl0it3r eXpl0it3r modified the milestones: 2.6.2, 2.6.1 Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants