Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typings could not be found #32

Closed
svelue opened this issue Oct 19, 2023 · 4 comments · Fixed by #35
Closed

Typings could not be found #32

svelue opened this issue Oct 19, 2023 · 4 comments · Fixed by #35

Comments

@svelue
Copy link
Contributor

svelue commented Oct 19, 2023

When importing collage with typescript the index.d.ts could not be found due to an error in the package.json.

Could not find a declaration file for module '@collage/core'. 'c:/.../node_modules/@collage/core/dist/collage.es.js' implicitly has an 'any' type.
There are types at 'c:/.../node_modules/@collage/core/dist/index.d.ts', but this result could not be resolved when respecting package.json "exports". The '@collage/core' library may need to update its package.json or typings.

@svelue
Copy link
Contributor Author

svelue commented Oct 19, 2023

I created a pull request for this one.
#33

@WanjaTschuorSICKAG
Copy link
Collaborator

Hi @svelue,

thank you for your contribution, I will test it as soon as possible.

WanjaTschuorSICKAG added a commit that referenced this issue Oct 27, 2023
@WanjaTschuorSICKAG
Copy link
Collaborator

Hi @svelue,

I reviewed, tested and merged your Pull Request. It will be part of our next release.
Before we publish the next release, we need to straighten some ts declarations.
I will keep this issue open as long as the work is ongoing.

@WanjaTschuorSICKAG
Copy link
Collaborator

This fix is part of the v0.2.10 release https://github.com/SICKAG/collage/releases/tag/v0.2.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants