Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple definition with BlobServerConfig when compiling static lib #2

Closed
arrfou99 opened this issue Jun 25, 2024 · 3 comments
Closed

Comments

@arrfou99
Copy link

When compiling this package as a static lib, I get multiple definition error of methods that are inside /shared/BlobServerConfig.h

I propose to add keyword inline to all methods or to have a cpp file of BlobServerConfig.h

I am compiling this package as static lib since it has more functionalities that I can use compared with the base package.

thank you

@xfealal
Copy link
Collaborator

xfealal commented Jul 2, 2024

Dear @arrfou99,

Thank you for your suggestion. We understand the issue you’re facing when compiling the package as a static library. Your proposal is appreciated. We’ll review this and make the necessary changes.

@xfealal
Copy link
Collaborator

xfealal commented Jul 25, 2024

Dear @arrfou99,
We want to inform you that we have incorporated your suggestions into the current release (1.1.0). The shared/cpp folder is now compiled into a static library called shared_cpp_utils. We hope this resolves the issues you encountered. Your feedback is appreciated.

@arrfou99
Copy link
Author

Great, thank you. we can close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants