fixed RangeError: Maximum call stack size exceeded. #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serebrennikovalex
changed the title
serebrennikovalex
changed the title
daynin
requested changes
Oct 1, 2019
lib/utils.js
Outdated
| @@ -458,7 +456,12 @@ export function moveElementAwayFromCollision( | |||
| const compactH = compactType === "horizontal"; | |||
| // Compact vertically if not set to horizontal | |||
| const compactV = compactType !== "horizontal"; | |||
| const preventCollision = false; // we're already colliding | |||
| let preventCollision = false; // we're already colliding | |||
There was a problem hiding this comment.
it can be done a little bit simpler:
const preventCollision = collidesWith.staticand, I think, we should change this comment we're already colliding -> we're already colliding (not for static items) and remove comment when preventCollision = false and element is static then we have RangeError: Maximum call stack size exceeded, it's better to place this comment into the commit message
There was a problem hiding this comment.
I agree, thank you.
…n = false and element is static
serebrennikovalex
force-pushed
the
bugfix/issue-941
branch
from
3575541 to
114c31c
Compare
daynin
approved these changes
Oct 4, 2019
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed RangeError: Maximum call stack size exceeded when dragging an element over a static element causes.
The point of the solution is that when we drag an element over a static one, a collision occurs and we have to interrupt the operation.
Fixes #941