Consistency: make onDrop callback more consistent #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 7 days |
github-actions
bot
added
the
stale
|
Thanks, this is a good idea. I'm doing a semver-major release (1.0.0) and this will make it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I need to have access to the layout on the onDrop callback. In other words, this PR doesn't solve any bug. But this callback still looks dirty compared to other callbacks, so I also try to make it more consistent with the rest of the app.
We can still improve that a bit, but I already create a PR so that we can talk about it as it is a major change to the way the callback is used.
Thanks