Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update FlowType version #995

Merged
merged 1 commit into from
Sep 27, 2019
Merged

chore: update FlowType version #995

merged 1 commit into from
Sep 27, 2019

Conversation

daynin
Copy link
Collaborator

@daynin daynin commented Sep 15, 2019

No description provided.

@daynin daynin requested review from STRML and n1ghtmare September 15, 2019 09:41
@daynin daynin self-assigned this Sep 15, 2019
STRML
STRML reviewed Sep 15, 2019
View reviewed changes
yarn.lock
@@ -5124,6 +5124,11 @@ lodash@^4.13.1, lodash@^4.17.10, lodash@^4.17.4, lodash@^4.17.5, lodash@^4.2.0,
resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.11.tgz#b39ea6229ef607ecd89e2c8df12536891cac9b8d"
integrity sha512-cQKh8igo5QUhZ7lg38DYWAxMvjSAKG0A8wGSVimP07SIUEK2UO+arSRKbRZWtelMtN5V0Hkwh5ryOto/SshYIg==

lodash@^4.17.15:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be possible to dedupe this with the previous lodash resolutions

@n1ghtmare
Copy link
Collaborator

@STRML @daynin I see that in the react-resizable repo there is a PR to get rid of componentWillReceiveProps, once it's merged and its version is updated, perhaps it will be a good idea to update all our dependencies here (before we push a new version). Let me know I can get right on it.

@daynin
Copy link
Collaborator Author

daynin commented Sep 18, 2019 •
edited
Loading

@n1ghtmare

once it's merged and its version is updated, perhaps it will be a good idea to update all our dependencies here (before we push a new version)

yes, I think that's a good idea!

I created an issue for it #1002

@STRML STRML merged commit 5826c18 into react-grid-layout:master Sep 27, 2019
@STRML STRML added this to the 0.17.0 milestone Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@STRML STRML STRML left review comments

@n1ghtmare n1ghtmare n1ghtmare approved these changes

Assignees

@daynin daynin

Labels
enhancement
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@daynin @n1ghtmare @STRML