Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Language detection #265

Open
ab-pandey opened this issue May 30, 2023 · 6 comments
Open

Improve Language detection #265

ab-pandey opened this issue May 30, 2023 · 6 comments

Comments

@ab-pandey
Copy link

ab-pandey commented May 30, 2023

Since wishper detects language based on first 30 secs of the audio, sometimes there are errors in language detection. For example
This video is in english but both whisper and faster_whisper detects language as hindi "hi". There is a solution for this issue in whisper here. Since I am new to Ctranslate2, I am having difficulty in cloning this solution to faster_whisper. Can someone help me on this? Thanks.
P.S. I have tested the solution in whisper and it works.

@guillaumekln
Copy link
Contributor

Since I am new to Ctranslate2, I am having difficulty in cloning openai/whisper#676 to faster_whisper. Can someone help me on this? Thanks

What have you tried so far? Maybe you can share your current changes and we can help you implement this.

@ab-pandey
Copy link
Author

Actually I am not able to figure out how to proceed further. There are several variables in the fix like "content_frames", "N_FRAMES", "segment"; functions used "pad_or_trim" in this solution which I am not able to figure out how to get the correct values for faster_whisper implementation

@ab-pandey ab-pandey reopened this Jun 13, 2023
@elloza
Copy link

elloza commented Feb 22, 2024

has been this implemented?

@dilerbatu
Copy link

Any update ?

@trungkienbkhn
Copy link
Collaborator

FYI, I created a new PR to implement this feature: #732

@ldolegowski92
Copy link

Do Twojej wiadomości, utworzyłem nowy PR, aby wdrożyć tę funkcję: #732

How will the model behave if the conditions are not met?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants